Block editor: iframe: fix placeholder colors #47416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +966 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
How about removing the mixin from gutenberg/packages/edit-site/src/style.scss Line 103 in de4a160 gutenberg/packages/edit-post/src/style.scss Line 100 in de4a160 |
|
I don't think we can remove from the main packages because these packages are meant to be used independently, regardless of whether we use an iframe or not. |
youknowriad
approved these changes
Jan 26, 2023
|
Flaky tests detected in 4da0b6db572690c0e90032d2e5023201683095fb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4032322029
|
ellatrix
force-pushed
the
fix/iframe-admin-colors
branch
from
4da0b6d
to
ad16216
Compare
juanmaguitar
added
the
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #47347.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast