Fix Nav block exhaustive deps warnings #48680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Code Quality
|
Size Change: +61 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
ajlende
force-pushed
the
fix/nav-block-exhaustive-deps-warnings
branch
from
641ee40 to
97006f2
Compare
ajlende
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves all exhaustive deps warnings for the Nav block code.
Why?
We've already encountered bugs due to missing deps. Now the rule is enabled let's resolve all the warnings and deal with any fallout.
How?
npm run lint:js packages/block-library/src/navigationTesting Instructions
npm run lint:js packages/block-library/src/navigation. See no warnings.Testing Instructions for Keyboard
Screenshots or screencast