Fix: Show creation popover on empty page links in the navigation sidebar. #48746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
|
Size Change: +86 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Thanks for working on this. Before before.mp4After after.mp4The popover position feels a bit unexpected, mostly because it hides the related menu item. Is there anything we could do about that? It's especially awkward when the popover is small:
It seems to be pinned to the top, left corner of the viewport rather than the menu item. Perhaps it's something for a different PR, but it's a bit strange how the empty Page Link receives the selected styling if you close the popover without choosing a page. It would be good to remove that. |
|
Sorry I missed a push: This is the expected position. It is still some pixels off if we have many items. I'm working on an alternative approach that may be even better. |
|
Flaky tests detected in 01c17e5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4326766623
|
|
It seems this change should also be backported in the Navigation block's list view as well? |
ntsekouras
pushed a commit
that referenced
this pull request
Mar 7, 2023
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 83d6dec |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
jorgefilipecosta
added
Backport to WP 6.7 Beta/RC
This was referenced Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the navigation sidebar and shows the page/custom link creation popover when the user clicks on an empty custom/page link block on the navigation sidebar.
Testing
Add a page link block on the navigation sidebar.
Leave it empty and close the popover.
Click on the block and verify the popover appears again.
Repeat the steps for the custom link case.