-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Navigation sidebar shows a wrong submenu popover. #48941
Merged
jorgefilipecosta
merged 1 commit into
trunk
from
fix/navigation-sidebar-shows-a-wrong-submenu-popover
Mar 8, 2023
Merged
Fix: Navigation sidebar shows a wrong submenu popover. #48941
jorgefilipecosta
merged 1 commit into
trunk
from
fix/navigation-sidebar-shows-a-wrong-submenu-popover
Mar 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
An existing feature does not function as intended
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
labels
Mar 8, 2023
Size Change: +39 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
jorgefilipecosta
deleted the
fix/navigation-sidebar-shows-a-wrong-submenu-popover
branch
March 8, 2023 20:17
Mamaduka
pushed a commit
that referenced
this pull request
Mar 9, 2023
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: fbf9413 |
Mamaduka
removed
the
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on the browse mode navigation sidebar when we click on a submenu an unexpected popover appears. This PR fixes the bug.
Testing
Add a menu with a submenu.
On the navigation, sidebar click on the parent of the submenu.
Verify this popover does not appear ( on the trunk it appears).