From d76466e684b66a5dd0775d7361142e710064ee0b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ella=20van=C2=A0Durpe?= Date: Wed, 8 Mar 2023 23:41:48 +0200 Subject: [PATCH] Block editor: hooks: fix rules of hooks violations (2) --- packages/block-editor/src/hooks/position.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/block-editor/src/hooks/position.js b/packages/block-editor/src/hooks/position.js index 32e8dc8530d37..cfccb23663aa0 100644 --- a/packages/block-editor/src/hooks/position.js +++ b/packages/block-editor/src/hooks/position.js @@ -334,8 +334,8 @@ export const withInspectorControls = createHigherOrderComponent( blockName, POSITION_SUPPORT_KEY ); - const showPositionControls = - positionSupport && ! useIsPositionDisabled( props ); + const isPositionDisabled = useIsPositionDisabled( props ); + const showPositionControls = positionSupport && ! isPositionDisabled; return [ showPositionControls && ( @@ -361,8 +361,9 @@ export const withPositionStyles = createHigherOrderComponent( name, POSITION_SUPPORT_KEY ); + const isPositionDisabled = useIsPositionDisabled( props ); const allowPositionStyles = - hasPositionBlockSupport && ! useIsPositionDisabled( props ); + hasPositionBlockSupport && ! isPositionDisabled; const id = useInstanceId( BlockListBlock ); const element = useContext( BlockList.__unstableElementContext );