[RNMobile] Disable block's touchable component when is focused #49691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
the
Mobile App - i.e. Android or iOS
fluiddot
added
the
Mobile App - Automation
fluiddot
commented
Apr 10, 2023
| @@ -215,7 +215,7 @@ class BlockListBlock extends Component { | |||
| order + 1 | |||
| ); | |||
| const { isFullWidth, isContainerRelated } = alignmentHelpers; | |||
| const accessible = ! ( isSelected || isInnerBlockSelected ); | |||
| const isFocused = isSelected || isInnerBlockSelected; | |||
There was a problem hiding this comment.
I considered the block as focused when is selected or when any of its inner blocks is selected.
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
jhnstn
approved these changes
Apr 10, 2023
|
Hey @jhnstn 👋 , would you mind also reviewing the GB-mobile PR? Thanks 🙇 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Disables the touchable component (
TouchableWithoutFeedback) used inBlockListBlockcomponent to gain focus when the block is already focused (i.e. selected or has an inner block selected).Why?
On Android, we detected that touchable components, like
TouchableWithoutFeedback, can disrupt touch events of inner components. Specifically, elements rendered within WebViews don't receive properly the touch events and break interaction of embedded content.How?
When a block is focused (i.e. selected or has an inner block selected), the
TouchableWithoutFeedbackcomponent, used to gain focus and select the block, is disabled via thedisabledprop. This change shouldn't introduce regressions as it's expected that selected blocks don't get selected again:gutenberg/packages/block-editor/src/components/block-list/block.native.js
Lines 132 to 137 in 38c1276
Testing Instructions
Blocks can be selected
Inner blocks can be selected
N/A
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A