Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] Disable block's touchable component when is focused #49691

Merged
merged 1 commit into from
Apr 12, 2023
Merged

[RNMobile] Disable block's touchable component when is focused #49691

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/block-editor/src/components/block-list/block.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ class BlockListBlock extends Component {
order + 1
);
const { isFullWidth, isContainerRelated } = alignmentHelpers;
const accessible = ! ( isSelected || isInnerBlockSelected );
const isFocused = isSelected || isInnerBlockSelected;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered the block as focused when is selected or when any of its inner blocks is selected.

const screenWidth = Math.floor( Dimensions.get( 'window' ).width );
const isScreenWidthEqual = blockWidth === screenWidth;
const isScreenWidthWider = blockWidth < screenWidth;
Expand All @@ -224,8 +224,9 @@ class BlockListBlock extends Component {
return (
<TouchableWithoutFeedback
onPress={ this.onFocus }
accessible={ accessible }
accessible={ ! isFocused }
accessibilityRole={ 'button' }
disabled={ isFocused }
>
<View
style={ { flex: 1 } }
Expand Down