Navigation: Fix warning when stretch justification is used #50568
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes the warning issue reported in #50550
In the Navigation block's PHP, check that the provided justification value is present in the mapping array before attempting to access it.
Why?
Since
stretch
was introduced as a valid value, whenstretch
is set on the Navigation block, it throws a warning when rendered on the site frontend.This PR doesn't implement proper support for
stretch
in this block — it's just looking at resolving this PHP warning.How?
Testing Instructions
stretch
content justification (the right-most option)stretch
doesn't really do anything for this block yet (I don't think), but double-check thatleft
,centre
,right
justifications still work as expectedTesting Instructions for Keyboard
Screenshots or screencast
This is the warning that should not be logged with this PR applied: