Remove custom padding on style revisions button #51269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -16 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Thanks for following up @jameskoster! I actually included that padding rule because otherwise the hover state doesn't line up with the save button when there are changes to be saved. On balance I thought perhaps it might be better to optimise for the hover state alignment? Happy to go with your lead here, though! Here's a before and after:
What do you think? |
|
I think it's more important for the revisions button to share alignment with all the other menu items that appear in the sidebar, rather than have its own custom styling. This will make it consistent with the sticky section in the Pages panel. The mis-alignment of the save button is an issue, but it's a detail to polish separately. |
andrewserong
approved these changes
Jun 7, 2023
|
I'll merge this in now 🙂 |
andrewserong
added
the
Global Styles
andrewserong
added
the
[Type] Bug
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #51149.
What?
Removes unnecessary padding on the revisions button in the Styles panel
Why?
It was slightly breaking alignment.
Before
After