-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Upgrade React Native 0.71.11
#51303
Changes from all commits
c70eb5b
13ad608
83b7a16
256be9c
213073d
cbdb7ff
bd0750b
6cac580
311ed3f
5b48573
ba8496a
ca395c2
2c0e048
809b82d
3f73574
e0cab59
97265c7
9f2edf4
a9d4165
70dbcc6
36ccef4
29457bb
88b679b
53ea3f9
6d30809
5be8a68
ac7d100
8bbaf2c
b5c02fd
556b3ef
fb14804
70a78c5
7988b0e
a756c3e
e5838f4
f879e29
86d36e0
8f36b9a
305db7f
39570ce
ad188ac
9b8d7be
de27968
b6f5fba
bb3afd8
bdd4704
2b3fa44
643860d
cf67f49
a5036dd
70c6dcb
2d0a219
470af37
0411df1
4482b9d
1f34e0c
20aaaf3
2fad54c
44b988a
0c79d79
fff11e9
8e496ba
7b423cd
7289045
3ef9edd
05e9748
c6b1311
29c2bed
61669c8
5040e6a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -63,7 +63,19 @@ exports[`Block Mover Picker should render without crashing and match snapshot 1` | |
accessibilityRole="button" | ||
accessibilityState={ | ||
{ | ||
"busy": undefined, | ||
"checked": undefined, | ||
"disabled": false, | ||
"expanded": undefined, | ||
"selected": undefined, | ||
} | ||
} | ||
accessibilityValue={ | ||
{ | ||
"max": undefined, | ||
"min": undefined, | ||
"now": undefined, | ||
"text": undefined, | ||
Comment on lines
+66
to
+78
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These new a11y values have been added in RN 0.71 (reference). |
||
} | ||
} | ||
accessible={true} | ||
|
@@ -130,7 +142,19 @@ exports[`Block Mover Picker should render without crashing and match snapshot 1` | |
accessibilityRole="button" | ||
accessibilityState={ | ||
{ | ||
"busy": undefined, | ||
"checked": undefined, | ||
"disabled": true, | ||
"expanded": undefined, | ||
"selected": undefined, | ||
} | ||
} | ||
accessibilityValue={ | ||
{ | ||
"max": undefined, | ||
"min": undefined, | ||
"now": undefined, | ||
"text": undefined, | ||
} | ||
} | ||
accessible={true} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,6 +44,7 @@ describe( 'MediaUpload component', () => { | |
const wrapper = render( | ||
<MediaUpload | ||
allowedTypes={ [ mediaType ] } | ||
onSelectURL={ jest.fn() } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This fixes a failure I encountered when running the tests. The error was related to missing the option "Insert from URL" on the Image and Audio block. After reviewing the logic of |
||
render={ ( { open, getMediaOptions } ) => { | ||
return ( | ||
<> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous warning is no longer shown when running the tests, seems that now a different one is displayed instead.