Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'Mamaduka' as one of the code owners for Playwright tests #51470

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Add 'Mamaduka' as one of the code owners for Playwright tests #51470

merged 1 commit into from
Jun 13, 2023

Conversation

Mamaduka
Copy link
Member

What?

I am adding myself as one of the code owners for the Playwright e2e tests directory.

Why?

I want to be notified when tests are added or updated. Also, I don't want @kevin940726 to have all the fun with tests 😄

Testing Instructions

CI checks are green.

@Mamaduka Mamaduka self-assigned this Jun 13, 2023
@Mamaduka Mamaduka added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Project Management Meta-issues related to project management of Gutenberg labels Jun 13, 2023
@github-actions
Copy link

Flaky tests detected in d39574e.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5258878394
📝 Reported issues:

alexstine
alexstine approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@alexstine alexstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Mamaduka
Copy link
Member Author

Thnaks, @alexstine!

@Mamaduka Mamaduka merged commit 97379fd into trunk Jun 13, 2023
@Mamaduka Mamaduka deleted the update/playwright-tests-codeowners branch June 13, 2023 19:09
@github-actions github-actions bot added this to the Gutenberg 16.1 milestone Jun 13, 2023
@kevin940726
Copy link
Member

Welcome to the club! 😂

sethrubenstein pushed a commit to pewresearch/gutenberg that referenced this pull request Jul 13, 2023
@Mamaduka @sethrubenstein
Add myself as one of the code owners for Playwright tests (WordPress#…
9ae5582 
…51470)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexstine alexstine alexstine approved these changes

@kevin940726 kevin940726 Awaiting requested review from kevin940726

Assignees

@Mamaduka Mamaduka

Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Project Management Meta-issues related to project management of Gutenberg
Projects
None yet
Milestone
Gutenberg 16.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Mamaduka @kevin940726 @alexstine