Site Editor: Fix browser console error in Library page #51756
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Code Quality
|
Size Change: -10 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in fa4de00. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5335803270
|
There was a problem hiding this comment.
Thank you for the fix @t-hamano 🚀
There's also #51762 by @ciampo that addresses this issue along with the tooltips on the back button.
I don't have strong opinions regarding the slightly different approaches.
There do appear to be some related e2e failures here, so perhaps it's easier to go with #51762?
|
Thanks for the review, @aaronrobertshaw!
Yes, I have no problem closing this PR and proceeding with #51762 👍 |
|
Thank you @t-hamano ! Going to close this PR as agreed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes a browser warning error that is output when the library page is opened in the site editor.
Why?
This is because if the
SIdebarButtoncomponent is passed to the icon prop of theDropdownMenucomponent, the button element will be nested.How?
Use
togglePropsprop.Testing Instructions
Verify that the browser console does not output an error when the Library page is opened in the Site Editor.