Inserter: Fix the in-between inserter on nested blocks #5282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Feature] Inserter
|
Nice, this is working well for me. Edit: Note that I know the nested UI needs work, and I'm working on that partially in #5217, which is difficult and a step on the way. Just saying the testing instructions work predictably here. |
aduth
approved these changes
Feb 27, 2018
There was a problem hiding this comment.
Confirmed this fixes:
- Between-inserter misalignment (both top-level and in nested context)
- Inserting at start of nested context
- Inserting within nested context
It does not fix:
- Vertical misalignment of the first block (Inserter: Try showing a "line" between two blocks on hover to insert a new empty block #5198 (comment))
- Blocks added via editor inserter (+) inserted out of order #5291
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #5198 (review)
This fixes the inserter (ine) showing up when you hover between blocks for nested blocks.
Testing instructions