Site Editor: Fix document actions label helper method #52974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
Mamaduka
commented
Jul 26, 2023
Comment on lines
+36
to
+47
| const isPage = useSelect( | ||
| ( select ) => select( editSiteStore ).isPage(), | ||
| [] | ||
| ); |
There was a problem hiding this comment.
Unrelated to the actual fix but a small code quality improvement.
|
Size Change: -27 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
Mamaduka
commented
Jul 26, 2023
| @@ -26,7 +26,7 @@ test.describe( 'Site editor title', () => { | |||
| 'role=region[name="Editor top bar"i] >> role=heading[level=1]' | |||
| ); | |||
|
|
|||
| await expect( title ).toHaveText( 'Editing template: Index' ); | |||
| await expect( title ).toHaveText( 'Editing template:Index' ); | |||
There was a problem hiding this comment.
I think there's no need for space here. a11y tree renders text correctly, and I re-tested with VoiceOver, which also reads it correctly.
Mamaduka
force-pushed
the
fix/document-actions-get-label-helper
branch
from
e22915b
to
24feb1f
Compare
|
Flaky tests detected in f50cf6a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5713898853
|
getdave
reviewed
Jul 27, 2023
| wp_template_part: __( 'Editing template part:' ), | ||
| }; | ||
|
|
||
| return labels[ entityType ] ?? labels.wp_template; |
There was a problem hiding this comment.
Because the default is template part when you edit a Page the title is not about editing a page but about editing a template part
There was a problem hiding this comment.
@getdave, I think you're looking at the wrong label in a11y tree. The pages use a different Actions component, which doesn't use this helper.
Screenshot
|
Sorry, @getdave. I think I wasn't clear on what part of the UI needs to be tested, adding a screenshot of the document actions component. Screenshot
|
Mamaduka
force-pushed
the
fix/document-actions-get-label-helper
branch
from
24feb1f
to
f50cf6a
Compare
|
I'm tentatively adding this to the WP 6.3.x board. IIRC, the untranslated string issue can be fixed in minor releases. |
Mamaduka
force-pushed
the
fix/document-actions-get-label-helper
branch
from
f50cf6a
to
4187634
Compare
tellthemachines
added
the
Backport to WP Minor Release
tellthemachines
pushed a commit
that referenced
this pull request
Aug 14, 2023
* Site Editor: Fix document actions label helper method * Add missing useSelect dep * Fix e2e tests * Move the label map at the file level to avoid recreating the object on every render
|
I just cherry-picked this PR to the update/bugfixes-6-3-1 branch to get it included in the next release: 49d7b13 |
tellthemachines
removed
the
Backport to WP Minor Release
tellthemachines
pushed a commit
that referenced
this pull request
Aug 31, 2023
* Site Editor: Fix document actions label helper method * Add missing useSelect dep * Fix e2e tests * Move the label map at the file level to avoid recreating the object on every render
tellthemachines
added a commit
that referenced
this pull request
Sep 1, 2023
* Update document title buttons radius (#53221) * Fix: Sync status overlaps for some languages in Patterns post type page (#53243) * Image block: Fix stretched images constrained by max-width (#53274) * Fix dragging to resize from stretching image in the frontend * Add image block v7 deprecation * Update deprecation comment * Prevent image losing its aspect ratio at smaller window dimensions * Revert "Prevent image losing its aspect ratio at smaller window dimensions" This reverts commit 8ac9f8c. --------- Co-authored-by: scruffian <ben@scruffian.com> * Image Block: Don't render `DimensionsTool` if it is not resizable (#53181) * Fix missing Replace button in content-locked Image blocks (#53410) * Revert "don't display BlockContextualToolbar at all in contentonly locking (#53110)" This reverts commit 5efce0e. * Alternative fix to hide BlockContextualToolbar when there are no controls * fix the go to for non pages by showing it only for pages (#53408) * Site Editor: Fix document actions label helper method (#52974) * Site Editor: Fix document actions label helper method * Add missing useSelect dep * Fix e2e tests * Move the label map at the file level to avoid recreating the object on every render * Image: Clear aspect ratio when wide aligned (#53439) * RichText: Remove 'Footnotes' when interactive formatting is disabled (#53474) Introduce a new 'interactive' setting for format types * Preserve block style variations when securing theme json (#53466) * Preserve block style variations when securing theme json Valid and safe block style variations were being removed by `WP_Theme_JSON_Gutenberg::remove_insecure_properties` when securing the theme.json. When this was a problem varied depending upon site configuration, but out-of-the-box it was a problem for administrators on multi-site installs. This change adds explicit processing of variations in `remove_insecure_properties` so that they won't get removed. * Add another variation sanitisation test This test checks that when removing insecure properties an unknown/unsupported property is removed from the variation. * Site editor: add missing i18n in `HomeTemplateDetails` (#53543) * Site editor: add missing i18n in `HomeTemplateDetails` * Lint fix * Fix: Snack bar not fixed on certain pages in the Site Editor (#53207) * Fix document title alignment in command palette button (#53224) * Fallback to default max viewport if layout wide size is fluid. (#53551) * Link Control: persist advanced settings toggle state to preferences if available (#52799) * Link Control: Create a preference for whether the advanced section is open * move the useSelect to the component that uses it * Supply preference setter via settings * Pass setter to Post Editor * Provide local state fallbacks in absence of preference store settings * Conditionalise display of settings drawer to “edit” mode only * Extract to constant to improve comprehension * Fix bug in preferences resolution * Improve comments * Add e2e scaffold * Fix e2e test to correctly assert on feature * Remove focused test * Reinstate original logic to hide settings when not required * Scaffold documentation * Revert providing prefs via settings * Refactor to use `core/block-editor` as preference scope * Update docs * Reinstate remaining original conditional * tentative fix for the e2e test * Try a different syntax for shiftAlt * another attempt to fix the e2e test --------- Co-authored-by: Dave Smith <getdavemail@gmail.com> Co-authored-by: MaggieCabrera <maggie.cabrera@automattic.com> * Add tests for fluid layout + typography (#53554) * Fix support of sticky position in non-iframed post editor (#53540) * Fix support of sticky position in non-iframed post editor * Revert "Footnotes: Fix recursion into updating attributes when attributes is not an object (#53257)" This reverts commit ab04074. * Fix: indicator style when block moving mode (#53972) * Fix post editor top toolbar with custom fields in Safari (#53688) * Set top toolbar size dynamically (#53526) * fix the top toolbar size in the space remaining after plugin items are pinned * only resize above the tablet breakpoint * fix fixed block toolbar collapse button when icon labels are shown * Update height and scroll behavior * move the layout effect to the affected component, fixes for fullscreen, no block selected, icon labels height --------- Co-authored-by: jasmussen <joen@automattic.com> * Roll back camelCase change in 96b6b1e --------- Co-authored-by: James Koster <james@jameskoster.co.uk> Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> Co-authored-by: Alex Lende <alex+github.com@lende.xyz> Co-authored-by: scruffian <ben@scruffian.com> Co-authored-by: Robert Anderson <robert@noisysocks.com> Co-authored-by: Andrei Draganescu <me@andreidraganescu.info> Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com> Co-authored-by: Dean Sas <dean.sas@automattic.com> Co-authored-by: Pascal Birchler <pascalb@google.com> Co-authored-by: Dave Smith <getdavemail@gmail.com> Co-authored-by: MaggieCabrera <maggie.cabrera@automattic.com> Co-authored-by: Mitchell Austin <mr.fye@oneandthesame.net> Co-authored-by: jasmussen <joen@automattic.com> Co-authored-by: ramon <ramonjd@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR updates the entity type label map for the document actions component to avoid missing translations. I've also added a missing label for patterns.
Why?
The previous method for concatenating translation strings isn't ideal. The
sprintfshould be used when strings aren't static.How?
Create a label map and return an entire string for a record type, fallback to the template when there's no label available.
Testing Instructions
Screenshots or screencast