Add context to the "Reset template" "Delete template" and "Edit template" commands #52989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Enhancement
|
Size Change: +1.13 kB (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
I like it, but it is a bit hard to scan with the added colon stop. What about if we used this breadcrumb approach, where it's a bit more clear? @WordPress/gutenberg-design what do you think of introducing a pattern like this for commands? As we get into adding additional context like in #51505 and #52509, this pattern will improve command readability. 
|
|
Can we use a typographic element instead of the chevron? The chevron reads to me like UI in that it's split in two commands vs. one, when it's the latter. Perhaps an emdash?
🤔 |
|
+1 for a typographical solution. Emdash or colon could work. Or wrapping the template name in quotes:
Should we include the delete action here too? |
|
Flaky tests detected in a7f1858. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5680636501
|
|
Here's another use case this would carry over to (per #52509): 
I'm not sure it conveys differently as an emdash: 
I still lean towards the chevron for clarity, emdash as a secondary option, if you both think its the right solution. |
|
Good point, that's certainly relevant as we attempt to establish consistency in the Command Palette actions. It actually makes me wonder if a colon might be better, with the format:
I'm going to cc @mcsf as I think you were involved in that discussion. If not feel free to ignore me 😁 |
|
Yep, makes sense to me. I think the need for a typographic glyph is mainly about establishing it as still a single action. |
|
Yes, the colon is a good choice — though for i18n purposes the chevron or dash would have been totally fine too, IMO (as long as it's rendered as a single string: |
t-hamano
reviewed
Jul 30, 2023
packages/edit-site/src/hooks/commands/use-edit-mode-commands.js
Outdated
Show resolved
Hide resolved
|
So, what's the verdict here regarding the copy ? 😄 |
|
Do we actually need a separator...? The
|
I think we do for some languages, but not 100% sure. Additionally could that work well without adding any context? For example if we had |
|
Yes good point. For example if you had a page titled "About" and a custom template for that page also titled "About" (not an outlandish supposition), a "Delete About" command could be confusing. In this case the actions could be more specific:
|
|
I would avoid using emdash. This is because there may be languages that do not use emdashes, and emdashes are inherently used to separate sentences. I prefer either of the following formats:
|
ntsekouras
changed the title
|
Anything else to do here? I'll be AFK next week and would love to wrap this up. Thanks! |
mikachan
added
[Package] Edit Site
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves: #51693
This PR adds more context to the "Reset template", "Delete template" and "Edit template" commands, by adding the template title in the form of
Delete template: ${name}. Additionally thereset templatecommand icon was updated torotateLeft.Testing Instructions
Test these three commands and observe that the template title is also part of the label.