-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish header for mobile and more languages #5329
Conversation
Also convert Switch to Draft from IconButton to Button, because that's what it is.
This is looking good, I pushed a small commit to fix the unit tests. The issue I have with the recent updates to the top is the spacing : The space between the publish button and the cog button in mobile is different. But it's more visible for me in desktop (which I think is not related to this PR). In that case, the space between "Publish" and "Preview" is too small compared to the space between "Publish" and the "cog" button. Looks good otherwise. |
I think we should start using CSS Grids more in our stylesheets to fix all these alignments and spacing issues at the parent level which is less subject to errors and updates. display: grid;
grid-auto-flow: column;
grid-gap: 5px;
align-content: center;
align-items: center; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Yep, that's intentional insofar as I've been trying to free up space to fit the most important buttons in multiple languages. German gets very long. I think improvement can certainly be made, and I like your grid work, but there's not much space we can use if we need to be able to show both preview and publish in german on an iPhone 5. So for now I think it's worth addressing separately, perhaps as part of #5343. Thanks for the review, merging (when the tests pass)! |
I don't care if it's the small spacing we choose between the buttons, I just prefer if it's consistent (just use a smaller |
Fixes #4231.
This PR enhances the editor-bar for mobile, and has been tested with German on an iPhone 5 screen.
It does a few things to free up space and be smart about the mobile UI:
Many further improvements can, and should, be made to the mobile UI. But this addresses the things that are directly broken, and aside from general future mobile polish, I would encourage opening separate tickets for mobile header space issues.
Screenshots: