Storybook: update doc param values for ConfirmDialog #54130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.51 MB ℹ️ View Unchanged
|
t-hamano
reviewed
Sep 3, 2023
There was a problem hiding this comment.
Thanks for the PR! I was just about to submit a similar PR 😄
- According to the documentation, the default value seems to be true, so I think removing the format property is not a problem.
- In addition, it may be a good idea to fix this indentation:
gutenberg/packages/components/src/confirm-dialog/stories/index.story.js
Lines 103 to 105 in 3b114f7
Some light formatting of default example code
ramonjd
force-pushed
the
fix/confirm-dialog-story-doc
branch
from
d38ee1c
to
317fa38
Compare
I left it in just in case the original author wanted to communicate it explicitly, but I guess it's fine to remove. Done!
No worries!
Ha, sorry! You are usually too fast! 🚤 Thank you for looking over it. 🙇🏻 |
|
Flaky tests detected in 317fa38. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6066797893
|
|
Going to merge this. Doesn't affect core plugin functionality and addresses the storybook bug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54123
What?
Just updating storybook doc format value with boolean in the
<ConfirmDialog />component. Formerly it was a string.Why?
Storybook was throwing an error:
Uncaught Error: Couldn't resolve parser "true". Parsers must be explicitly added to the standalone bundle.Testing Instructions
Run
npm run storybook:devand head to:http://localhost:50240/?path=/docs/components-experimental-confirmdialog--docs
You should see the docs page.