Mobile - RichText - Update logic for the placeholder text color #54259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
[Type] Enhancement
|
Size Change: +963 B (0%) Total Size: 1.52 MB
ℹ️ View Unchanged
|
…ock font size for block-based themes
|
Flaky tests detected in cd5411d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6136661090
|
geriux
added
the
Mobile App - Automation
13 tasks
derekblank
approved these changes
Sep 11, 2023
|
LGTM! |
geriux
removed
the
Mobile App - Automation
4 tasks
|
@geriux what opacity value did you use for placeholders? I'm not noticing a huge distinction in some places. |
We are using a hexadecimal color code for the transparency, for the placeholders is |
|
ok cool thanks, 63% sounds good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Fixes wordpress-mobile/gutenberg-mobile#6069
What?
This PR updates the logic for the placeholder text colors for the RichText component and block-based themes.
Why?
Previously, the same colors were displayed for both the placeholder text and the populated RichText component.
How?
Opacity is added to the placeholder text color, utilizing the default text color derived from the theme settings.
The update also resolves a pre-existing issue where the empty placeholder displayed a smaller font size in instances where the current theme had a font size larger than the mobile editor's default. The font size now aligns with the Paragraph block's default size.
Testing Instructions
Precondition: Use a block-based theme like
DidoneScreenshots or screencast
Note: Screenshots done using the Didone theme.