-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix overwriting of published post meta when previewing footnote changes #54339
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamsilverstein, just to clarify: this is a different bug discovered while working on #52988 and can be tested/merged separately + recommended to be backported into a minor release.
Are the above statements correct?
P.S. Can you also provide quick testing instructions?
I think we can merge this PR, update_post_meta is just an update_metadata call, with additional logic to in case of revisions update the original post instead of the revision.
Here it seems we want to avoid that logic to have the possibility of having revisions for the footnones. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me 👍
If the e2e fails again, it might require rebasing due to core changes. See #54452. |
Rebased against trunk |
Fixes bug discovered in #52988
What?
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast