From aa24990163ec2b2a4f4c1ba82304591a11307154 Mon Sep 17 00:00:00 2001 From: Rich Tabor Date: Tue, 26 Sep 2023 14:14:19 -0400 Subject: [PATCH 1/2] Add help text & clearer labeling --- .../inserter/block-patterns-filter.js | 30 +++++++++++++------ 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/packages/block-editor/src/components/inserter/block-patterns-filter.js b/packages/block-editor/src/components/inserter/block-patterns-filter.js index 92a65efbd5c54..e88c34d752c80 100644 --- a/packages/block-editor/src/components/inserter/block-patterns-filter.js +++ b/packages/block-editor/src/components/inserter/block-patterns-filter.js @@ -7,10 +7,11 @@ import { DropdownMenu, MenuGroup, MenuItemsChoice, + ExternalLink, } from '@wordpress/components'; import { __ } from '@wordpress/i18n'; import { Icon } from '@wordpress/icons'; -import { useMemo } from '@wordpress/element'; +import { useMemo, createInterpolateElement } from '@wordpress/element'; /** * Internal dependencies @@ -73,13 +74,11 @@ export function BlockPatternsSyncFilter( { { value: SYNC_TYPES.full, label: __( 'Synced' ), - info: __( 'Updated everywhere' ), disabled: shouldDisableSyncFilter, }, { value: SYNC_TYPES.unsynced, - label: __( 'Standard' ), - info: __( 'Edit freely' ), + label: __( 'Not synced' ), disabled: shouldDisableSyncFilter, }, ], @@ -95,20 +94,17 @@ export function BlockPatternsSyncFilter( { }, { value: PATTERN_TYPES.directory, - label: __( 'Directory' ), - info: __( 'Pattern directory & core' ), + label: __( 'Pattern Directory' ), disabled: shouldDisableNonUserSources, }, { value: PATTERN_TYPES.theme, label: __( 'Theme' ), - info: __( 'Bundled with the theme' ), disabled: shouldDisableNonUserSources, }, { value: PATTERN_TYPES.user, label: __( 'User' ), - info: __( 'Custom created' ), }, ], [ shouldDisableNonUserSources ] @@ -149,7 +145,7 @@ export function BlockPatternsSyncFilter( { > { () => ( <> - + { @@ -175,6 +171,22 @@ export function BlockPatternsSyncFilter( { value={ patternSyncFilter } /> +
+ { createInterpolateElement( + __( + 'Patterns are available from the WordPress.org Pattern Directory, bundled in the active theme, or created by users on this site. Only patterns created on this site can be synced.' + ), + { + Link: ( + + ), + } + ) } +
) } From 41f5103c1094126bc514a991409decbb3579e4b5 Mon Sep 17 00:00:00 2001 From: Rich Tabor Date: Fri, 29 Sep 2023 12:11:00 -0400 Subject: [PATCH 2/2] Theme & Plugins --- .../src/components/inserter/block-patterns-filter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/block-editor/src/components/inserter/block-patterns-filter.js b/packages/block-editor/src/components/inserter/block-patterns-filter.js index e88c34d752c80..0d6cabe6c239f 100644 --- a/packages/block-editor/src/components/inserter/block-patterns-filter.js +++ b/packages/block-editor/src/components/inserter/block-patterns-filter.js @@ -99,7 +99,7 @@ export function BlockPatternsSyncFilter( { }, { value: PATTERN_TYPES.theme, - label: __( 'Theme' ), + label: __( 'Theme & Plugins' ), disabled: shouldDisableNonUserSources, }, {