[RNMobile] HTML mode: Add dark mode color to post title #54927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
[Type] Bug
fluiddot
changed the title
|
Size Change: 0 B Total Size: 1.62 MB ℹ️ View Unchanged
|
geriux
approved these changes
Sep 29, 2023
fluiddot
deleted the
rnmobile/fix/dark-mode-html-text-input-title-color
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In HTML mode and with dark mode enabled, the post title might be not visible due to using the same color as the background. This issue only happens when using themes that don't provide global styles.
Why?
This issue affects negatively the experience when editing in HTML mode.
How?
Adds a style to be used in the title element when in dark mode.
Testing Instructions
...button and "Switch to HTML mode".Testing Instructions for Keyboard
N/A
Screenshots or screencast