[Mobile] Update E2E Simulators #55589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
[Type] Automated Testing
2 tasks
|
Size Change: 0 B Total Size: 1.69 MB ℹ️ View Unchanged
|
dcalhoun
approved these changes
Oct 25, 2023
Comment on lines
+17
to
+18
| - `xcrun simctl create "iPhone 14" "iPhone 14" "com.apple.CoreSimulator.SimRuntime.iOS-16-2"` | ||
| - `xcrun simctl create "iPad (10th generation)" "iPad (10th generation)" "com.apple.CoreSimulator.SimRuntime.iOS-16-2"` |
There was a problem hiding this comment.
It is likely worth noting this change as a comment on the internal announcement post for contributors, as I do not believe these simulators would be available by default.
2 tasks
Yeah, it'd be great to have just one source of truth and other places would get the value from it. Once we remove SauceLabs we will simplify the config file and it would be a good opportunity to do this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
What?
This PR updates the E2E simulators.
Why?
To use newer simulators available with the current Xcode version
14.How?
Now it will use the
iPhone 14andiPad (10th generation)simulators.It also updates the documentation accordingly.
Testing Instructions
CI checks should pass.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A