From 6dad2987dc1e1b10ac84d04dc5b8ec71b7147f5a Mon Sep 17 00:00:00 2001 From: Dave Smith Date: Wed, 6 Dec 2023 15:00:27 +0000 Subject: [PATCH 1/6] Alter wording --- .../src/page-list/convert-to-links-modal.js | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/packages/block-library/src/page-list/convert-to-links-modal.js b/packages/block-library/src/page-list/convert-to-links-modal.js index cd4049fecff58..8f20c7b4deaa2 100644 --- a/packages/block-library/src/page-list/convert-to-links-modal.js +++ b/packages/block-library/src/page-list/convert-to-links-modal.js @@ -4,8 +4,15 @@ import { Button, Modal } from '@wordpress/components'; import { __ } from '@wordpress/i18n'; -export const convertDescription = __( - 'This page list is synced with the published pages on your site. Detach the page list to add, delete, or reorder pages yourself.' +import { createInterpolateElement } from '@wordpress/element'; + +export const convertDescription = createInterpolateElement( + __( + "The page list displays your site's published pages. If you choose to independently edit, your navigation will no longer automatically update when your pages change." + ), + { + em: , + } ); export function ConvertToLinksModal( { onClick, onClose, disabled } ) { From e01b6cccf895baae6258eb916082c8211bd9b946 Mon Sep 17 00:00:00 2001 From: Dave Smith Date: Wed, 6 Dec 2023 15:00:40 +0000 Subject: [PATCH 2/6] Make button name match intention --- packages/block-library/src/page-list/convert-to-links-modal.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/block-library/src/page-list/convert-to-links-modal.js b/packages/block-library/src/page-list/convert-to-links-modal.js index 8f20c7b4deaa2..c9fd714e41f8e 100644 --- a/packages/block-library/src/page-list/convert-to-links-modal.js +++ b/packages/block-library/src/page-list/convert-to-links-modal.js @@ -37,7 +37,7 @@ export function ConvertToLinksModal( { onClick, onClose, disabled } ) { disabled={ disabled } onClick={ onClick } > - { __( 'Detach' ) } + { __( 'Edit' ) } From 7b30fef50b60725f88f144b37ff4b9f318758113 Mon Sep 17 00:00:00 2001 From: Dave Smith Date: Thu, 7 Dec 2023 09:43:50 +0000 Subject: [PATCH 3/6] Update wording --- packages/block-library/src/page-list/convert-to-links-modal.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/block-library/src/page-list/convert-to-links-modal.js b/packages/block-library/src/page-list/convert-to-links-modal.js index c9fd714e41f8e..56a69583bea2b 100644 --- a/packages/block-library/src/page-list/convert-to-links-modal.js +++ b/packages/block-library/src/page-list/convert-to-links-modal.js @@ -8,7 +8,7 @@ import { createInterpolateElement } from '@wordpress/element'; export const convertDescription = createInterpolateElement( __( - "The page list displays your site's published pages. If you choose to independently edit, your navigation will no longer automatically update when your pages change." + "This menu is currently displaying your website's pages. Editing it will allow you to add, delete, or reorder pages, but new pages will no longer be automatically added to this navigation." ), { em: , From 19e7a726859207b9ad78e0045abfee9c200e2f2a Mon Sep 17 00:00:00 2001 From: Dave Smith Date: Thu, 7 Dec 2023 17:02:36 +0000 Subject: [PATCH 4/6] Use tweaked wording --- packages/block-library/src/page-list/convert-to-links-modal.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/block-library/src/page-list/convert-to-links-modal.js b/packages/block-library/src/page-list/convert-to-links-modal.js index 56a69583bea2b..4ea4abc43ead5 100644 --- a/packages/block-library/src/page-list/convert-to-links-modal.js +++ b/packages/block-library/src/page-list/convert-to-links-modal.js @@ -8,7 +8,7 @@ import { createInterpolateElement } from '@wordpress/element'; export const convertDescription = createInterpolateElement( __( - "This menu is currently displaying your website's pages. Editing it will allow you to add, delete, or reorder pages, but new pages will no longer be automatically added to this navigation." + "This navigation menu is currently displaying your website's pages. Editing it will allow you to add, delete, or reorder pages, but new pages will no longer be automatically added." ), { em: , From 663be97f59815bb7390d3dd262770ccb07d9d609 Mon Sep 17 00:00:00 2001 From: Rich Tabor Date: Thu, 7 Dec 2023 17:38:14 -0500 Subject: [PATCH 5/6] Copy tweak + remove emphasis --- .../src/page-list/convert-to-links-modal.js | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/packages/block-library/src/page-list/convert-to-links-modal.js b/packages/block-library/src/page-list/convert-to-links-modal.js index 4ea4abc43ead5..e0d4a704dcc34 100644 --- a/packages/block-library/src/page-list/convert-to-links-modal.js +++ b/packages/block-library/src/page-list/convert-to-links-modal.js @@ -4,15 +4,8 @@ import { Button, Modal } from '@wordpress/components'; import { __ } from '@wordpress/i18n'; -import { createInterpolateElement } from '@wordpress/element'; - -export const convertDescription = createInterpolateElement( - __( - "This navigation menu is currently displaying your website's pages. Editing it will allow you to add, delete, or reorder pages, but new pages will no longer be automatically added." - ), - { - em: , - } +export const convertDescription = __( + "The navigation menu displays your website's pages. Editing it will enable you to add, delete, or reorder pages. However, new pages will no longer be added automatically." ); export function ConvertToLinksModal( { onClick, onClose, disabled } ) { From ec3314691709570122af27f38144a8bf6d361c89 Mon Sep 17 00:00:00 2001 From: Rich Tabor Date: Thu, 7 Dec 2023 17:39:35 -0500 Subject: [PATCH 6/6] Tweak --- packages/block-library/src/page-list/convert-to-links-modal.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/block-library/src/page-list/convert-to-links-modal.js b/packages/block-library/src/page-list/convert-to-links-modal.js index e0d4a704dcc34..f47b5e3de259d 100644 --- a/packages/block-library/src/page-list/convert-to-links-modal.js +++ b/packages/block-library/src/page-list/convert-to-links-modal.js @@ -5,7 +5,7 @@ import { Button, Modal } from '@wordpress/components'; import { __ } from '@wordpress/i18n'; export const convertDescription = __( - "The navigation menu displays your website's pages. Editing it will enable you to add, delete, or reorder pages. However, new pages will no longer be added automatically." + "This navigation menu displays your website's pages. Editing it will enable you to add, delete, or reorder pages. However, new pages will no longer be added automatically." ); export function ConvertToLinksModal( { onClick, onClose, disabled } ) {