Migrate Site Editor 'settings sidebar' e2e tests to Playwright #57392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
the
[Type] Automated Testing
Mamaduka
requested review from
kevin940726,
ntwb,
nerrad and
ajitbohra
as code owners
Mamaduka
commented
Dec 27, 2023
Comment on lines
+55
to
+60
| const templateTitle = settingsSideber.locator( | ||
| '.edit-site-sidebar-card__title' | ||
| ); | ||
| const templateDescription = settingsSideber.locator( | ||
| '.edit-site-sidebar-card__description' | ||
| ); |
There was a problem hiding this comment.
Had to use the class locator here.
Mamaduka
requested review from
WunderBart and
t-hamano
and removed request for
ntwb,
ajitbohra and
nerrad
Mamaduka
commented
Dec 27, 2023
Comment on lines
+38
to
+42
| await expect( | ||
| page | ||
| .getByRole( 'region', { name: 'Editor settings' } ) | ||
| .getByRole( 'button', { name: 'Template (selected)' } ) | ||
| ).toHaveClass( /is-active/ ); |
There was a problem hiding this comment.
I think we can improve active tab assertions after #56959 is merged.
Untested example:
await expect(
page
.getByRole( 'region', { name: 'Editor settings' } )
.getByRole( 'tab', { selected: true } )
).toHaveText( 'Template' );There was a problem hiding this comment.
The active tab assertions work like a charm - https://github.com/WordPress/gutenberg/pull/57446/files.
|
Size Change: 0 B Total Size: 1.69 MB ℹ️ View Unchanged
|
t-hamano
approved these changes
Dec 27, 2023
|
Thank you, @t-hamano! |
github-actions
bot
added
the
[Status] In Progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851.
PR migrates
site-editor/settings-sidebar.test.jse2e tests to Playwright.Why?
See #38851.
Testing Instructions