From d4dd64ab4c4f8c2ff0fa71e76346616fef348cb4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Maneiro?= <583546+oandregal@users.noreply.github.com> Date: Wed, 8 May 2024 10:54:01 +0200 Subject: [PATCH 1/2] Fix regression on keyboard navigation --- packages/dataviews/src/view-list.tsx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/dataviews/src/view-list.tsx b/packages/dataviews/src/view-list.tsx index d88f11de59eed..f236e2061714b 100644 --- a/packages/dataviews/src/view-list.tsx +++ b/packages/dataviews/src/view-list.tsx @@ -40,7 +40,7 @@ interface ListViewProps { } interface ListViewItemProps { - id: string; + id: any; item: Item; isSelected: boolean; onSelect: ( item: Item ) => void; @@ -183,7 +183,8 @@ export default function ViewList( props: ListViewProps ) { ); const getItemDomId = useCallback( - ( item?: Item ) => ( item ? `${ baseId }-${ getItemId( item ) }` : '' ), + ( item?: Item ) => + item ? `${ baseId }-${ getItemId( item ) }` : undefined, [ baseId, getItemId ] ); From 53282308fc7052e19ca0be626d1e6d121c8e4adc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9?= <583546+oandregal@users.noreply.github.com> Date: Wed, 8 May 2024 11:39:24 +0200 Subject: [PATCH 2/2] Update packages/dataviews/src/view-list.tsx Co-authored-by: Riad Benguella --- packages/dataviews/src/view-list.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/dataviews/src/view-list.tsx b/packages/dataviews/src/view-list.tsx index f236e2061714b..193e89012fb89 100644 --- a/packages/dataviews/src/view-list.tsx +++ b/packages/dataviews/src/view-list.tsx @@ -40,7 +40,7 @@ interface ListViewProps { } interface ListViewItemProps { - id: any; + id?: string; item: Item; isSelected: boolean; onSelect: ( item: Item ) => void;