Update Private API opt-in string for WP 6.6. #62635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterwilsoncc
added
[Type] Task
peterwilsoncc
requested review from
ellatrix,
fluiddot,
dcalhoun,
talldan,
ajitbohra,
draganescu,
adamziel,
kevin940726,
nerrad,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +136 B (+0.01%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
talldan
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Smoke tested the PR, and everything's working well.
Also searched for the old string, and only found it in the README where it's expected to be.
Looks like the only thing failing is the (optional) changelog check for the components package. Not sure if it's worth adding something for private APIs, I'd be happy to merge without an entry.
Thanks for handling this @peterwilsoncc.
ellatrix
pushed a commit
that referenced
this pull request
Jun 18, 2024
Co-authored-by: peterwilsoncc <peterwilsoncc@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org>
ellatrix
pushed a commit
that referenced
this pull request
Jun 18, 2024
Co-authored-by: peterwilsoncc <peterwilsoncc@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org>
|
I just cherry-picked this PR to the wp/6.6-beta-3 branch to get it included in the next release: 6ac4b98 |
ellatrix
added
Backported to WP Core
ellatrix
pushed a commit
that referenced
this pull request
Jun 18, 2024
Co-authored-by: peterwilsoncc <peterwilsoncc@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org>
Merged
7 tasks
7 tasks
pkevan
added a commit
to WordPress/pattern-directory
that referenced
this pull request
Jul 8, 2024
Broke pattern creator, as reported in: https://wordpress.slack.com/archives/C02QB8GMM/p1720180116195859
pkevan
added a commit
to WordPress/pattern-directory
that referenced
this pull request
Jul 8, 2024
…700) Broke pattern creator, as reported in: https://wordpress.slack.com/archives/C02QB8GMM/p1720180116195859
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update the opt-in string for Private APIs for use in WordPress 6.6
Why?
The opt-in string is intended to be rotated on a regular basis to prevent themes and plugins from opting in to private and unstable APIs.
How?
Search and replace of the previous string.
Testing Instructions
I know using unstable features means my theme or plugin will inevitably break in the next version of WordPress.and ensure it only appears in the history section of the private api's readme file.Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A