Comments: Allow button element shadows from theme.json #63790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
2 tasks
|
Size Change: +19 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Nice simple fix! Reducing this slightly sounds good to me and is fitting with the intention of these styles, which is a good default for the submit button.
✅ Shadows in theme.json on the comments button element are now applied to the comments submit button in the post editor, while editing a template, and in template preview mode
✅ Shadows are applied correctly in the site frontend
LGTM! 🚀
carolinan
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #63767
What?
Reduces specificity of comments form button default styles to allow theme.json global button element shadows to take effect.
Why?
Allows comments form button to match global button styles.
How?
Wrap the inner
input[type="submit"]selector in:where()Testing Instructions
styles.elements.button.shadow:"shadow": "10px 10px 5px 0px rgba(0,0,0,0.66)"Screenshots or screencast
Before
After