From 23fc716cdd91fc1ba46107d94de1a3a201cadf2b Mon Sep 17 00:00:00 2001 From: shail-mehta Date: Tue, 6 Aug 2024 22:30:25 +0530 Subject: [PATCH 1/5] Comment Pagination Previous: Add Border Support --- .../comments-pagination-previous/block.json | 19 ++++++++++++++++++- .../comments-pagination-previous/style.scss | 4 ++++ packages/block-library/src/style.scss | 2 ++ 3 files changed, 24 insertions(+), 1 deletion(-) create mode 100644 packages/block-library/src/comments-pagination-previous/style.scss diff --git a/packages/block-library/src/comments-pagination-previous/block.json b/packages/block-library/src/comments-pagination-previous/block.json index 0871b000c569dd..3c675faac196dc 100644 --- a/packages/block-library/src/comments-pagination-previous/block.json +++ b/packages/block-library/src/comments-pagination-previous/block.json @@ -38,6 +38,23 @@ }, "interactivity": { "clientNavigation": true + }, + "spacing": { + "margin": true, + "padding": true + }, + "__experimentalBorder": { + "radius": true, + "color": true, + "width": true, + "style": true, + "__experimentalDefaultControls": { + "radius": true, + "color": true, + "width": true, + "style": true + } } - } + }, + "style": "wp-block-comments-pagination-previous" } diff --git a/packages/block-library/src/comments-pagination-previous/style.scss b/packages/block-library/src/comments-pagination-previous/style.scss new file mode 100644 index 00000000000000..da3a5086ed09e9 --- /dev/null +++ b/packages/block-library/src/comments-pagination-previous/style.scss @@ -0,0 +1,4 @@ +.wp-block-comments-pagination-previous { + // This block has customizable padding, border-box makes that more predictable. + box-sizing: border-box; +} \ No newline at end of file diff --git a/packages/block-library/src/style.scss b/packages/block-library/src/style.scss index 8f17cd7a50f55c..0c95adea5a847d 100644 --- a/packages/block-library/src/style.scss +++ b/packages/block-library/src/style.scss @@ -61,5 +61,7 @@ @import "./verse/style.scss"; @import "./video/style.scss"; @import "./footnotes/style.scss"; +@import "./comments-pagination-previous/style.scss"; + @import "common.scss"; From 56cafd4583029676e7a1fd82c136b04a93771ddb Mon Sep 17 00:00:00 2001 From: shail-mehta Date: Tue, 6 Aug 2024 22:36:53 +0530 Subject: [PATCH 2/5] Comment Pagination Previous: Add Border Support --- packages/block-library/src/style.scss | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/block-library/src/style.scss b/packages/block-library/src/style.scss index 0c95adea5a847d..59789f42add283 100644 --- a/packages/block-library/src/style.scss +++ b/packages/block-library/src/style.scss @@ -63,5 +63,4 @@ @import "./footnotes/style.scss"; @import "./comments-pagination-previous/style.scss"; - @import "common.scss"; From 8d22dfbd8ed919aedd783e72b7cd54c90b46544f Mon Sep 17 00:00:00 2001 From: shail-mehta Date: Tue, 6 Aug 2024 22:47:05 +0530 Subject: [PATCH 3/5] Fixed Lint Issue --- .../block-library/src/comments-pagination-previous/style.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/block-library/src/comments-pagination-previous/style.scss b/packages/block-library/src/comments-pagination-previous/style.scss index da3a5086ed09e9..1b0019da1834f2 100644 --- a/packages/block-library/src/comments-pagination-previous/style.scss +++ b/packages/block-library/src/comments-pagination-previous/style.scss @@ -1,4 +1,4 @@ .wp-block-comments-pagination-previous { // This block has customizable padding, border-box makes that more predictable. box-sizing: border-box; -} \ No newline at end of file +} From 06f4c783c93e51df0c666d7e97979077508ff505 Mon Sep 17 00:00:00 2001 From: shail-mehta Date: Tue, 6 Aug 2024 23:01:16 +0530 Subject: [PATCH 4/5] Comment Pagination Previous: Add Border Support --- docs/reference-guides/core-blocks.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/reference-guides/core-blocks.md b/docs/reference-guides/core-blocks.md index 72281a53c3dd18..a379a4d2a0666f 100644 --- a/docs/reference-guides/core-blocks.md +++ b/docs/reference-guides/core-blocks.md @@ -226,7 +226,7 @@ Displays the previous comment's page link. ([Source](https://github.com/WordPres - **Name:** core/comments-pagination-previous - **Category:** theme - **Parent:** core/comments-pagination -- **Supports:** color (background, gradients, ~~text~~), interactivity (clientNavigation), typography (fontSize, lineHeight), ~~html~~, ~~reusable~~ +- **Supports:** color (background, gradients, ~~text~~), interactivity (clientNavigation), spacing (margin, padding), typography (fontSize, lineHeight), ~~html~~, ~~reusable~~ - **Attributes:** label ## Comments Title From b86dbef93d5b819eb5c711553955d06b3c5865f7 Mon Sep 17 00:00:00 2001 From: shail-mehta Date: Thu, 8 Aug 2024 21:58:57 +0530 Subject: [PATCH 5/5] Added suggested changes --- .../src/comments-pagination-previous/block.json | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/packages/block-library/src/comments-pagination-previous/block.json b/packages/block-library/src/comments-pagination-previous/block.json index 3c675faac196dc..0d3374661abf6f 100644 --- a/packages/block-library/src/comments-pagination-previous/block.json +++ b/packages/block-library/src/comments-pagination-previous/block.json @@ -41,19 +41,17 @@ }, "spacing": { "margin": true, - "padding": true + "padding": true, + "__experimentalDefaultControls": { + "margin": false, + "padding": false + } }, "__experimentalBorder": { "radius": true, "color": true, "width": true, - "style": true, - "__experimentalDefaultControls": { - "radius": true, - "color": true, - "width": true, - "style": true - } + "style": true } }, "style": "wp-block-comments-pagination-previous"