From 0feeda37dc376f0152647241f5a06775c1420df6 Mon Sep 17 00:00:00 2001 From: George Mamadashvili Date: Fri, 6 Sep 2024 12:14:16 +0400 Subject: [PATCH 1/2] Block Editor: Use the tooltip from a button in 'ButtonBlockAppender' --- .../components/button-block-appender/index.js | 38 ++++++++----------- 1 file changed, 16 insertions(+), 22 deletions(-) diff --git a/packages/block-editor/src/components/button-block-appender/index.js b/packages/block-editor/src/components/button-block-appender/index.js index 9cd745ac5eb3d6..1b5907a2f5afa3 100644 --- a/packages/block-editor/src/components/button-block-appender/index.js +++ b/packages/block-editor/src/components/button-block-appender/index.js @@ -6,7 +6,7 @@ import clsx from 'clsx'; /** * WordPress dependencies */ -import { Button, Tooltip, VisuallyHidden } from '@wordpress/components'; +import { Button, VisuallyHidden } from '@wordpress/components'; import { forwardRef, useRef } from '@wordpress/element'; import { _x, sprintf } from '@wordpress/i18n'; import { Icon, plus } from '@wordpress/icons'; @@ -43,22 +43,22 @@ function ButtonBlockAppender( blockTitle, hasSingleBlockType, } ) => { - let label; - if ( hasSingleBlockType ) { - label = sprintf( - // translators: %s: the name of the block when there is only one - _x( 'Add %s', 'directly add the only allowed block' ), - blockTitle - ); - } else { - label = _x( - 'Add block', - 'Generic label for block inserter button' - ); - } const isToggleButton = ! hasSingleBlockType; + const label = hasSingleBlockType + ? sprintf( + // translators: %s: the name of the block when there is only one + _x( + 'Add %s', + 'directly add the only allowed block' + ), + blockTitle + ) + : _x( + 'Add block', + 'Generic label for block inserter button' + ); - let inserterButton = ( + return ( ); - - if ( isToggleButton || hasSingleBlockType ) { - inserterButton = ( - { inserterButton } - ); - } - return inserterButton; } } isAppender /> From 53f8635e681a00781a0fec2ecda79b9d913e0aa5 Mon Sep 17 00:00:00 2001 From: George Mamadashvili Date: Fri, 6 Sep 2024 12:15:36 +0400 Subject: [PATCH 2/2] Remove visually hidden element --- .../src/components/button-block-appender/index.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/block-editor/src/components/button-block-appender/index.js b/packages/block-editor/src/components/button-block-appender/index.js index 1b5907a2f5afa3..c4a6854c6d6cc4 100644 --- a/packages/block-editor/src/components/button-block-appender/index.js +++ b/packages/block-editor/src/components/button-block-appender/index.js @@ -6,7 +6,7 @@ import clsx from 'clsx'; /** * WordPress dependencies */ -import { Button, VisuallyHidden } from '@wordpress/components'; +import { Button } from '@wordpress/components'; import { forwardRef, useRef } from '@wordpress/element'; import { _x, sprintf } from '@wordpress/i18n'; import { Icon, plus } from '@wordpress/icons'; @@ -78,9 +78,6 @@ function ButtonBlockAppender( label={ label } showTooltip > - { ! hasSingleBlockType && ( - { label } - ) } );