Allow resetting the permalink by saving it as empty #6615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ved as an empty string.
pento
added
[Type] Bug
noisysocks
approved these changes
May 7, 2018
|
|
||
| $response->data['permalink_template'] = $sample_permalink[0]; | ||
|
|
||
| if ( 'draft' === $post->post_status && ! $post->post_name ) { | ||
| $response->data['draft_slug'] = $sample_permalink[1]; |
There was a problem hiding this comment.
🤔 Removing this is technically a breaking change. Since it was added recently and isn't documented, though, my feeling is that it's fine to leave as is.
There was a problem hiding this comment.
Yah, it's only in Gutenberg: there's not even a ticket for adding it to Core yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#6603 reports a permalink workflow from the classic editor that doesn't work in the block editor:
The permalink should be reset to the auto-generated permalink: this should work for both draft and published posts.
This PR makes a few change to support this flow:
draft_slugproperty togenerated_slug, and make it available on all posts, not just drafts.generated_slugis the generated slug, rather than defaulting to theslug, when that's set.PostPermalinkEditorto be saved with an empty permalink.How has this been tested?
To test, run through the workflow with a few variations:
Checklist: