Global styles: move preload paths filter to 6.7 (previously 6.8) #66543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
added
Backport from WordPress Core
| @@ -1,3 +1,4 @@ | |||
| https://github.com/WordPress/wordpress-develop/pull/7661 | |||
|
|
|||
| * https://github.com/WordPress/gutenberg/pull/66468 | |||
| * https://github.com/WordPress/gutenberg/pull/66543 | |||
There was a problem hiding this comment.
I think this might need moving to the 6.7 backport-changelog folder too.
andrewserong
approved these changes
Oct 29, 2024
aaronrobertshaw
approved these changes
Oct 29, 2024
|
Thanks for the quick reviews, folks! |
ramonjd
added a commit
that referenced
this pull request
Oct 29, 2024
…tyles (#66468) (#66542) * Sync with #66543 * Move backport log to 6.7 --------- Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
ramonjd
added a commit
that referenced
this pull request
Oct 30, 2024
…n post editor. Sync with #66543
ramonjd
added a commit
that referenced
this pull request
Oct 30, 2024
…n post editor. Sync with #66543 Update comment
cbravobernal
added
the
Global Styles
peterwilsoncc
pushed a commit
to peterwilsoncc/gutenberg-build
that referenced
this pull request
Oct 30, 2024
…tyles (#66468) (#66542) * Sync with WordPress/gutenberg#66543 * Move backport log to 6.7 --------- Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Source: WordPress/gutenberg@cf008a0
ramonjd
added a commit
that referenced
this pull request
Oct 31, 2024
…n post editor. Sync with #66543 Update comment
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…dPress#66543) * Given that this fixes a 6.7 regression move the code into 6.7 compat. * Move for loop into context block * Move backport log to 6.7 Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow up to:
#66468 will be cherry picked to 6.7 since it's a regression.
Why?
Given that this fixes a 6.7 regression move the code into 6.7 compat.
How?
Copy paste
Testing Instructions
Fire up this branch and head to the site editor.
Check that global-styles endpoints aren't fetched client side, but are, rather, preloaded via rest_preload_api_request
Do the same for the post editor.
Screenshots or screencast