Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContrastChecker: Add font size logic inside the component; Add additional test cases; #8059

Merged
merged 1 commit into from
Jul 20, 2018
Merged

ContrastChecker: Add font size logic inside the component; Add additional test cases; #8059

merged 1 commit into from
Jul 20, 2018

Commits on Jul 20, 2018

  1. Add font size logic to ContrastChecker component; Add test cases; 

    Contrast checker included logic to differentiate between large and small text. The logic is dependent on fontSize so it makes sense to have for normal cases logic that uses the fontSize inside ContrastChecker checker. But because the logic is not just dependent on fontSize (e.g: if text is bold for the same fontSize the contrast may be valid) we allow users of the component to still rely on isLargetext prop and decide by them selfs if the text they contain is considered large or not.
    @jorgefilipecosta
    jorgefilipecosta committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    f7d752e View commit details
    Browse the repository at this point in the history