Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern statuses #56

Closed
coreymckrill opened this issue Mar 30, 2021 · 2 comments · Fixed by #75
Closed

Pattern statuses #56

coreymckrill opened this issue Mar 30, 2021 · 2 comments · Fixed by #75
Assignees
Labels
[Component] Pattern Directory API The pattern API on WordPress.org, and/or the CPT endpoint [Component] Pattern Directory The backend of the pattern directory: submission, management, etc

Comments

@coreymckrill
Copy link
Contributor

coreymckrill commented Mar 30, 2021

  • draft The pattern has not been submitted to the directory yet, or it was submitted but failed automated validation checks. See Inform the user that a pattern has been saved/validated #36
  • awaiting-review (or maybe just use pending?) The automated checks determined that a human review is also needed. This could also be used when a published pattern gets flagged as inappropriate.
  • declined The pattern was declined by a human reviewer. See Create "My Submitted Patterns" page #16
  • publish The pattern passed automated checks and/or human review. It is now published in the pattern directory and appears in searches via the API.
  • removed The pattern was previously published, but was removed either by the author or a moderator. See Create "My Submitted Patterns" page #16

There is also some discussion in #16 of having patterns that are only available to the pattern author until the author chooses to publish them. So an additional status might be:

  • private The pattern has been submitted, and passed automated checks, but has not been published by the author.
@coreymckrill coreymckrill added [Component] Pattern Directory API The pattern API on WordPress.org, and/or the CPT endpoint [Component] Pattern Directory The backend of the pattern directory: submission, management, etc labels Mar 30, 2021
@ryelle
Copy link
Contributor

ryelle commented Mar 30, 2021

I think submitted should be draft - I see the word "submitted" and I think it's done and awaiting review.

Do you think we need a special status for invalid? If it doesn't pass validation checks, I think it would just not move on from draft. Maybe this should be a meta value on the pattern, rather than a custom status?

The private idea is not a launch requirement, but good to keep in mind.

@ryelle ryelle added this to the Initial Launch milestone Mar 30, 2021
@coreymckrill
Copy link
Contributor Author

Ok, updated to consolidate draft/invalid into one status. Maybe we don't even need to save a meta value on the pattern if it's invalid, if the author will receive a detailed message about the validation errors in the UI.

coreymckrill added a commit that referenced this issue Apr 7, 2021
This simply registers the two post statuses to be used for patterns that
aren't already built-in. There could be need in the future for more
functionality around these statuses, but we can build that as needed
in separate PRs.

Fixes #56
@coreymckrill coreymckrill self-assigned this Apr 7, 2021
coreymckrill added a commit that referenced this issue Apr 8, 2021
This simply registers the two post statuses to be used for patterns that
aren't already built-in. There could be need in the future for more
functionality around these statuses, but we can build that as needed
in separate PRs.

Fixes #56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Pattern Directory API The pattern API on WordPress.org, and/or the CPT endpoint [Component] Pattern Directory The backend of the pattern directory: submission, management, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants