-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport: Navigation Post Preloading in Site Editor #4628
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a small feedback concerning a small docblock issue :)
@getdave This new file needs to be loaded in wp-settings.php |
Understood. My first time doing backports. Let me get this sorted. |
@getdave See my feedback on trac ticket before continuing. |
Preload paths for Navigation have now be inlined directly in the Site Editor file as per recommendations. |
'per_page' => 100, | ||
'order' => 'desc', | ||
'orderby' => 'date', | ||
'_locale' => 'user', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The javascript should be refactored so this rest api call is not made twice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. We're tracking it in WordPress/gutenberg#51803
Not sure what's going on with the CI tests here. I believe I now wait for a Core Committer to merge this? |
Yes! If @tellthemachines can't get to it today, hopefully someone will sweep in tonight and commit. Thanks again! |
Adds a
navigation.php
file to hold all hooks/utilites relating to Navigation in the Block Editor.Backports over the preloading hook for Navigation Posts.
Trac ticket: https://core.trac.wordpress.org/ticket/58556
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.