HTML API: add get/set inner/outer markup #4956
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmsnell
changed the title
dmsnell
force-pushed
the
html-api/add-get-set-inner-outer-contents
branch
2 times, most recently
from
e2a7146
to
851b3c7
Compare
dmsnell
changed the title
dmsnell
force-pushed
the
html-api/add-get-set-inner-outer-contents
branch
5 times, most recently
from
060d219
to
de410cd
Compare
dmsnell
changed the title
dmsnell
force-pushed
the
html-api/add-get-set-inner-outer-contents
branch
2 times, most recently
from
242e8ba
to
18cc399
Compare
dmsnell
force-pushed
the
html-api/add-get-set-inner-outer-contents
branch
3 times, most recently
from
6698cd9
to
43db05f
Compare
dmsnell
force-pushed
the
html-api/add-get-set-inner-outer-contents
branch
from
43db05f
to
79bf013
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Do not merge: This incorporates two other PRs, which may change before they are merged.
Todo
substr_bookmarksandreplace_with_bookmarksQuestions
rawto the names to indicate even more that these are making potentially-destructive operations? This doesn't escape HTML because it can't, if it's already provided an HTML string. This also doesn't validate semantic rules, for example, adding a paragraph inside a paragraph. e.g.set_raw_inner_markup()Description
Trac ticket:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.