Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML API: Use Tag Processor instead of RegExp for URL details controller #5547

Draft
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

dmsnell
Copy link
Member

@dmsnell dmsnell commented Oct 21, 2023

No description provided.

@dmsnell dmsnell force-pushed the explore/html-api/url-details-controller branch 5 times, most recently from 55255ba to a0a2668 Compare October 21, 2023 21:55
@dmsnell dmsnell force-pushed the explore/html-api/url-details-controller branch from a0a2668 to 7ccc43d Compare October 21, 2023 22:04
@getdave
Copy link
Contributor

getdave commented Jan 11, 2024

@dmsnell Is there any likelihood of us being able to land this? A lot of things look red. Are you aware of any major tasks that need to happen in order for this to progress? Thank you.

@dmsnell
Copy link
Member Author

dmsnell commented Jan 11, 2024

@getdave the errors held me up. there's a combination of failed tests and test failures. I think it'll take some work to sort through it, but I do hope to merge it once it's ready.

did you have thoughts or wants for it?

@getdave
Copy link
Contributor

getdave commented Jan 12, 2024

Rich Tabor and I were discussing it away from Github. Sometimes the existing endpoint doesn't do a great job of processing the HTML and thus some of the data is not unavailable when you would expect it to be.

This endpoint is used in the preview of the link interface within the block editor to display preview of a given link.

It's relatively low priority but I mentioned to Rich that improving this endpoint would provide us with more reliable data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants