Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground PR Previews as a GitHub App or a generic GitHub action #1138

Open
adamziel opened this issue Mar 25, 2024 · 6 comments
Open

Playground PR Previews as a GitHub App or a generic GitHub action #1138

adamziel opened this issue Mar 25, 2024 · 6 comments

Comments

@adamziel
Copy link
Collaborator

adamziel commented Mar 25, 2024

Let's make the automatic "PR Preview" comment easy to integrate with any repo:

CleanShot 2024-03-25 at 14 58 44@2x

Currently it's a custom wordpress-develop GitHub workflow. It should be reusable with some manual copy&paste&adjust work. I'd love to turn it into a GitHub App that could be installed in any repo and configured with an artifact name and a default message. It would help many WordPress ecosystem projects.

Here's some inspiration to reuse:

cc @ockham @ndiego

@ndiego
Copy link
Member

ndiego commented Mar 25, 2024

Over the weekend, I was experimenting with Playground blueprints for my personal repos (Icon Block example). I modified a shields.io badge for "Playground Demo" and then linked it to the blueprint in the repo. I like the way it turned out, but a more standardized approach would be cool.

image

@ockham
Copy link
Contributor

ockham commented Mar 25, 2024

Love it!

I'd love to turn it into a GitHub App that could be installed in any repo and configured with an artifact name and a default message.

My first guess was actually to extract a reusable GitHub Action (which is arguably lower-level and would likely require users to be a bit more experienced). I haven't worked with GH Apps really; is it reasonable to assume that we'd need the action anyway, and the app would be built around it?

@adamziel
Copy link
Collaborator Author

@ockham I'm not sure actually! But a reusable action would also go a long way. A GitHub App is an implementation detail, a GitHub link to start a new PR that adds a new yml workflow would be just as good.

@adamziel adamziel added the Good First Issue Good for newcomers label Jun 12, 2024
@adamziel adamziel moved this to Project: Up Soon in Playground Board Jun 30, 2024
@adamziel adamziel moved this from Project: Triage to Project: Not now in Playground Board Jul 1, 2024
@adamziel adamziel changed the title Playground PR Previews as a GitHub App Playground PR Previews as a GitHub App or a generic GitHub action Jul 16, 2024
@adamziel
Copy link
Collaborator Author

adamziel commented Aug 2, 2024

@vcanales
Copy link
Member

vcanales commented Aug 2, 2024

@adamziel thanks for creating the issues! Making the action more flexible was definitely in my radar, and this is a great roadmap for that.

@adamziel
Copy link
Collaborator Author

There's now a GitHub action for this available in an official WordPress repository: https://github.com/WordPress/action-wp-playground-pr-preview

Let's still keep this issue open until:

  • That action can handle plugins, not just themes
  • That action is easy to find for anyone interested in previewing their WordPress PRs – this could involve Playground docs, blog posts, and even in-Playground links and integrations such as "set up PR previews for your repo" link. CC @akirk @bph.

@adamziel adamziel removed this from the Innovative Developer Tools milestone Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants