-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add redirect for removed block editor tutorial. #254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR is against the not-yet-released developer theme, it'll need to be applied to the (This change still needs to be made, it just needs an additional commit to the other branch) |
@dd32 this branch, right? |
Switching branches caused a bit of a mess on this PR, so I just created a fresh one here. |
@dd32 It doesn't appear that the redirect is working. Navigating to https://developer.wordpress.org/block-editor/how-to-guides/platform/custom-block-editor/tutorial/ leads to a 404 when not logged in. Did I mess something up? |
@ndiego I think I failed to actually deploy this change, sorry about that! should be fixed now:
|
I ran the sync. Try it now. |
The redirection works now. Thanks! |
WordPress/gutenberg#53159 consolidates the Building a custom block editor and Tutorial: building a custom block editor into one doc. This PR adds a redirect from the removed tutorial doc to the main page.
Once #53159 is merged, this redirect will be needed.