Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redirect for removed block editor tutorial. #254

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

ndiego
Copy link
Member

@ndiego ndiego commented Jul 31, 2023

WordPress/gutenberg#53159 consolidates the Building a custom block editor and Tutorial: building a custom block editor into one doc. This PR adds a redirect from the removed tutorial doc to the main page.

Once #53159 is merged, this redirect will be needed.

adamwoodnz
adamwoodnz previously approved these changes Aug 1, 2023
Copy link
Contributor

@adamwoodnz adamwoodnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dd32
Copy link
Member

dd32 commented Aug 2, 2023

This PR is against the not-yet-released developer theme, it'll need to be applied to the old branch to apply to the currently deployed developer.wordpress.org.

(This change still needs to be made, it just needs an additional commit to the other branch)

@adamwoodnz adamwoodnz dismissed their stale review August 2, 2023 02:18

Changes needed

@ndiego
Copy link
Member Author

ndiego commented Aug 2, 2023

@dd32 this branch, right?

@ndiego ndiego changed the base branch from trunk to old August 2, 2023 13:41
@ndiego ndiego changed the base branch from old to trunk August 2, 2023 13:41
@ndiego
Copy link
Member Author

ndiego commented Aug 2, 2023

Switching branches caused a bit of a mess on this PR, so I just created a fresh one here.

@ndiego ndiego closed this Aug 2, 2023
@dd32 dd32 reopened this Aug 3, 2023
@dd32 dd32 merged commit 65df8f2 into WordPress:trunk Aug 3, 2023
2 checks passed
dd32 added a commit that referenced this pull request Aug 3, 2023
@ndiego ndiego deleted the patch-1 branch August 7, 2023 15:43
@ndiego
Copy link
Member Author

ndiego commented Aug 7, 2023

@dd32 It doesn't appear that the redirect is working. Navigating to https://developer.wordpress.org/block-editor/how-to-guides/platform/custom-block-editor/tutorial/ leads to a 404 when not logged in. Did I mess something up?

@dd32
Copy link
Member

dd32 commented Aug 8, 2023

@ndiego I think I failed to actually deploy this change, sorry about that! should be fixed now:

$ curl -Is 'https://developer.wordpress.org/block-editor/how-to-guides/platform/custom-block-editor/tutorial/' | grep -Ei '^(HTTP|Location)'
HTTP/2 301
location: https://developer.wordpress.org/block-editor/how-to-guides/platform/custom-block-editor

@StevenDufresne
Copy link
Contributor

I ran the sync. Try it now.

@juanmaguitar
Copy link

The redirection works now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants