Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Upgrade engine.io from 6.5.0 to 6.6.2 #116

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

X-oss-byte
Copy link
Owner

@X-oss-byte X-oss-byte commented Nov 6, 2024

snyk-top-banner

Snyk has created this PR to upgrade engine.io from 6.5.0 to 6.6.2.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 9 versions ahead of your current version.

  • The recommended version was released on a month ago.

Issues fixed by the recommended upgrade:

Issue Score Exploit Maturity
medium severity Cross-site Scripting (XSS)
SNYK-JS-COOKIE-8163060
529 No Known Exploit
Release notes
Package name: engine.io
  • 6.6.2 - 2024-10-09

    Bug Fixes

    • types: remove ws type from .d.ts file (175a2c5)
    • prevent infinite loop with Node.js built-in WebSocket (4865f2e)

    Dependencies

  • 6.6.1 - 2024-09-21

    Bug Fixes

    • move 'offline' event listener at the top (8a2f5a3)
    • only remove the event listener if it exists (9b3c9ab)
    • do not send a packet on an expired connection (#5134) (8adcfbf)

    Performance Improvements

    • do not reset the heartbeat timer on each packet (7a23dde)

    Dependencies

  • 6.6.0 - 2024-06-21
  • 6.5.5 - 2024-06-18
  • 6.5.4 - 2023-11-09
  • 6.5.3 - 2023-10-06
  • 6.5.2 - 2023-08-02
  • 6.5.2-alpha.1 - 2023-08-01
  • 6.5.1 - 2023-06-27
  • 6.5.0 - 2023-06-16
from engine.io GitHub release notes

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • This PR was automatically created by Snyk using the credentials of a real user.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

Summary by Sourcery

Upgrade the engine.io dependency from version 6.5.0 to 6.6.2 to address a Cross-site Scripting (XSS) vulnerability and improve overall security.

Bug Fixes:

  • Fix a Cross-site Scripting (XSS) vulnerability by upgrading engine.io to version 6.6.2.

Build:

  • Upgrade engine.io dependency from version 6.5.0 to 6.6.2 in package.json.

Snyk has created this PR to upgrade engine.io from 6.5.0 to 6.6.2.

See this package in npm:
engine.io

See this project in Snyk:
https://app.snyk.io/org/sammytezzy/project/0c2e6abe-c98c-464b-82b2-c5b800caf132?utm_source=github&utm_medium=referral&page=upgrade-pr
Copy link

stackblitz bot commented Nov 6, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Nov 6, 2024

⚠️ No Changeset found

Latest commit: 771bf66

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

sourcery-ai bot commented Nov 6, 2024

Reviewer's Guide by Sourcery

This PR upgrades the engine.io dependency from version 6.5.0 to 6.6.2 to address a medium severity Cross-site Scripting (XSS) vulnerability. The upgrade spans 9 versions and includes various bug fixes, performance improvements, and security patches.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Dependency version upgrade in package configuration files
  • Updated engine.io dependency from ~6.5.0 to ~6.6.2
  • Addresses medium severity XSS vulnerability (SNYK-JS-COOKIE-8163060)
  • Includes bug fixes for WebSocket connections and type definitions
  • Adds performance improvements for heartbeat timer handling
package.json
package-lock.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. It seems to have been created by a bot ('[Snyk]' found in title). We assume it knows what it's doing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants