Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Break out defense modifiers instead of combining them into one row #1295

Closed
Tedster59 opened this issue Jan 7, 2024 · 0 comments · Fixed by #1340
Closed

Enhancement: Break out defense modifiers instead of combining them into one row #1295

Tedster59 opened this issue Jan 7, 2024 · 0 comments · Fixed by #1340

Comments

@Tedster59
Copy link
Contributor

One thing XModBase does is split the one "defense" modifier into multiple rows for each modifier instead of combining them.

image

This is a good QOL enhancement, and doesn't appear to be something I can easily duplicate with existing CHL hooks in a sublcass as there isn't a good way to removing existing modifiers without nuking everything and starting over, defeating the point of using the GetAdditionalHitModifiers_CH hook in my attempt to refactor XModBase.

Integrating this will allow me to refactor XModBase without losing functionality.

@Iridar Iridar added this to the 1.29.0 milestone May 2, 2024
Iridar pushed a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue May 3, 2024
@Iridar Iridar removed this from the 1.29.0 milestone May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants