Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pawn is not updated correctly when some part changes only differ by override material #354

Closed
MrNiceUK opened this issue Nov 27, 2018 · 1 comment
Closed

Pawn is not updated correctly when some part changes only differ by override material #354

MrNiceUK opened this issue Nov 27, 2018 · 1 comment
Labels
bug-highlander

Comments

@MrNiceUK
Copy link
Contributor

MrNiceUK commented Nov 27, 2018 •
edited
Loading

For helmets, this was broken by PR #272, which replaced a content comparison with a skeletal mesh comparison only, and did not include a material override comparison . For several arm related parts, they do not actually compare against the correct override, most likely from the code not being correctly updated from copypasta when Anarchy's Children introduced separate left/right arm parts and arm decos.
@MrNiceUK MrNiceUK reopened this Nov 27, 2018
@MrNiceUK MrNiceUK changed the title Random armour appearance (from equipping an armour not used before) does not respect DLC/Mod Part Pack sliders Pawn is not updated correctly when some part changes only differ by override material Nov 27, 2018
MrNiceUK added a commit to MrNiceUK/X2WOTCCommunityHighlander that referenced this issue Nov 27, 2018
@MrNiceUK
X2CommunityCore#354 fixes
6d8f807
@MrNiceUK MrNiceUK mentioned this issue Nov 27, 2018
Closed
@Musashi1584 Musashi1584 mentioned this issue Oct 17, 2019
Merged
@robojumper
Copy link
Member

I believe this was fixed in #351 =)

@E3245 E3245 mentioned this issue Nov 25, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug-highlander
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robojumper @MrNiceUK