Prevent hack rewards from being granted multiple times #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iridar
added
bug-basegame
ready-to-review
Iridar
force-pushed
the
990-fix-hack-rewards
branch
from
6601f96
to
1a2c78f
Compare
Iridar
force-pushed
the
990-fix-hack-rewards
branch
from
0b647c5
to
d24eb04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #990
Would also make Skulljack Feedback Fix obsolete.
This fix lived happily in Core Collection Meta Mod for over two years and I had no complaints, and it's well tested, so I'm confident in it.
Also, I checked, abilities created using the
X2Ability_HackRewards::ApplyEffectsToTemplate()that useclass'XComGameState_Ability'.static.HackTriggerTargetListenerdo not suffer from this problem and don't require fixing.It's worth noting that the proposed fix addresses only hack rewards from the base game. Mod added hack rewards (that are currently potentially fixed by CCMM) will not be affected.
Also, there's a hack reward "control all robots" in Shen's Last Gift, but since it can be obtained only by hacking one particular enemy, who obviously can't be hacked more than once, I think it's safe to ignore that one.