-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #917 - Update EndTacticalHealthMod() in XCGS_Unit to expose beta strike post mission healing to config #1202
Issue #917 - Update EndTacticalHealthMod() in XCGS_Unit to expose beta strike post mission healing to config #1202
Conversation
X2WOTCCommunityHighlander/Src/XComGame/Classes/XComGameState_Unit.uc
Outdated
Show resolved
Hide resolved
X2WOTCCommunityHighlander/Src/XComGame/Classes/XComGameState_Unit.uc
Outdated
Show resolved
Hide resolved
X2WOTCCommunityHighlander/Src/XComGame/Classes/XComGameState_Unit.uc
Outdated
Show resolved
Hide resolved
Issues resolved - ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's still a formatting issue with HL-Docs.
A HL-Docs entry must look either like this:
/// HL-Docs: feature:YourFeature; issue:1337;
or like this:
/// HL-Docs: feature:YourFeature; issue:1337; tags:tactical
Tags are optional.
Either ///
or ;;;
are used depending on whether this is in script or in config.
Each feature must have at least one HL-Docs entry like this, where both feature name and issue number are specified.
All other HL-Docs entries should have only the feature name with the ref
keyword:
;;; HL-Docs: ref:YourFeature;
All comments under HL-Docs entry that are also prefaced with ///
or ;;;
get pulled into the Highlander online documentation automatically, where the entry with the feature
and issue
is used to generate the header, while all other entries with ref
are appended to the page.
The only exception to this rule is the ref:Bugfixes
, which looks like this:
HL-Docs: ref:Bugfixes; issue:644
And it has both a ref
and an issue
number.
6ba9d53
to
cd0fba8
Compare
Please tell me it's right this time! Changed committed & pushed :) |
It looks right to me, but the docs builder still fails for some reason. We need the sempai. |
(c) sempai |
cd0fba8
to
da7591f
Compare
The docs builder still fails, sorry, looks like I was wrong and the Try it like this:
|
…XComGame.ini to disable the additional 50% healing the game automatically gives to soldiers at the end of a mission when beta strike is active. Updated code in XCGS_Unit to use the new bool variable. If the variable is false, or doesn't exist , the base game behaviour will be retained.
da7591f
to
87407b2
Compare
OK last time! Please work! |
Praise Johnny Lump! |
Fixes #917
Added a boolean value to CHHelpers & updated code in EndTacticalHealthMod() in XCGS_Unit to allow other mods to set a config variable in XComGame.ini to disable the additional 50% health the game automatically grants to soldiers at the end of a mission when beta strike is active.
If the variable is false, or doesn't exist , the base game behaviour is retained.