Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If a damage effect ignores armor, max out Pierce in its Damage Preview #1283

Merged
merged 1 commit into from
Oct 29, 2023
Merged

If a damage effect ignores armor, max out Pierce in its Damage Preview #1283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions X2WOTCCommunityHighlander/Src/XComGame/Classes/X2Effect_ApplyWeaponDamage.uc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,6 +660,16 @@ simulated function GetDamagePreview(StateObjectReference TargetRef, XComGameStat

if (!bDoesDamageIgnoreShields)
AllowsShield += MaxDamagePreview.Damage;

// Start Issue #1281
/// HL-Docs: ref:Bugfixes; issue:1281
/// If the effect ignores all armor, max out the Pierce value in the Damage Preview so it will show up on the unit flag damage preview.
if (bIgnoreArmor)
{
MinDamagePreview.Pierce = MaxInt;
MaxDamagePreview.Pierce = MaxInt;
}
// End Issue #1281
}

simulated function ApplyFalloff( out int WeaponDamage, Damageable Target, XComGameState_Item kSourceItem, XComGameState_Ability kAbility, XComGameState NewGameState )
Expand Down