Apply weapon customization when equipping unmodified weapons #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… equipping unmodified weapons.
Iridar
added
the
ready-for-merge
|
I think this is fine, but I'll let it stew for a bit in case @robojumper decides to give it a look. |
|
One thing that has me slightly concerned is using weapon pattern for weapons that are supposed to armor appearance. Like, wouldn't it make sense to use armor pattern for them? But this is what existing code does, so I'll cargo cult this for now. This can be changed later if need be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #609
This PR does fix the outlined issue, but I need more tests to determine it doesn't go overboard. For example, when working with non-infinite weapons that have weapon upgrades applied to them, but no upgrade slots, e.g. TLP weapons or Chosen XCOM weapons.