Prevent rupture bonus damage from being added to attack that don't deal damage #1344
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1299
Addendum to #1330, which has removed the cap from bonus damage that can be applied to an attack by rupture, which was previously capped by the attack's base damage. This was deemed a bug, because Rupture's description says "adds +3 damage to following attacks", but in effect this can be +1 or +2 if the following attack did that much damage.
What has escaped the consideration is that the cap also prevented bonus damage from rupture from applying at all if the damage effect ended up doing zero damage.
Removing the cap allowed effects that normally don't do damage outside of specific circumstances, such as the Stock Miss Damage effect, to benefit from Rupture, even if the bonus damage from the Stock itself is not applied - because it was set to zero or because the weapon doesn't even have a stock equipped, presumably.