Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent rupture bonus damage from being added to attack that don't deal damage #1344

Merged
merged 1 commit into from
May 6, 2024

Conversation

Iridar
Copy link
Contributor

@Iridar Iridar commented May 6, 2024

Issue #1299

Addendum to #1330, which has removed the cap from bonus damage that can be applied to an attack by rupture, which was previously capped by the attack's base damage. This was deemed a bug, because Rupture's description says "adds +3 damage to following attacks", but in effect this can be +1 or +2 if the following attack did that much damage.

What has escaped the consideration is that the cap also prevented bonus damage from rupture from applying at all if the damage effect ended up doing zero damage.

Removing the cap allowed effects that normally don't do damage outside of specific circumstances, such as the Stock Miss Damage effect, to benefit from Rupture, even if the bonus damage from the Stock itself is not applied - because it was set to zero or because the weapon doesn't even have a stock equipped, presumably.

@Iridar Iridar added this to the 1.28.1 milestone May 6, 2024
@Iridar Iridar self-assigned this May 6, 2024
@Iridar Iridar changed the title Issue #1299 - prevent rupture bonus damage from being added to attack… Prevent rupture bonus damage from being added to attack that don't deal damage May 6, 2024
@Iridar Iridar merged commit ca23b71 into X2CommunityCore:master May 6, 2024
4 checks passed
@Iridar Iridar deleted the fix-rupture-stock-damage branch May 6, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants