-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom explainxkcd rendering #114
Comments
I have no plans to do this myself but happy to accept a PR implementing this. :) |
For anyone looking to implement, https://www.explainxkcd.com/wiki/index.php/418:_Stove_Ownership?action=render would be a nice starting point and https://www.mediawiki.org/wiki/API:Main_page has docs for an API that can return in JSON, XML or PHP. |
Actually, while the rest isn't done, I'll PR the starting point. Edit: Nevermind I can't navigate swift lol |
I have tracked the code down to https://github.com/XKCDY/app/blob/master/XKCDY/Support/XKCDYClient.swift#L42 . @codetheweb Is there a way to automatically append ?action=render to the explainURL property of whatever the returned thing is? I have no idea what this entire result thing is 😅 |
I would probably add it within https://github.com/XKCDY/app/blob/master/XKCDY/Views/ComicDetailsSheet.swift rather than at time of API response. Might be easier to toggle between this and the old rendering method as well with a user setting. |
So you're saying (without the setting) it would be |
Go for it 👍 |
I love this app, but the explainxkcd rendering is quite inconvenient, especially on iPhone. I was wondering if you could get their Wikitext (through their API), render the headings and links, and just slap them into the app?
The text was updated successfully, but these errors were encountered: