Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can transfer excess funds infinitely #13

Open
matthewjablack opened this issue Apr 26, 2018 · 0 comments
Open

Can transfer excess funds infinitely #13

matthewjablack opened this issue Apr 26, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@matthewjablack
Copy link
Member

The transferExcess has a flaw which allows an attacker to exploit excess funds multiple times. There needs to be a modifier and state change that checks if excess funds have been withdrawn.

Steps to reproduce:

Create Market
Lend 10Ξ Account 0
Borrow 5Ξ Account 1
Withdraw 5Ξ Account 1
Repay 5Ξ Account 1
Collect 5Ξ Account 0
Transfer Excess 5Ξ Account 0
Transfer Excess 5Ξ Account 0
@matthewjablack matthewjablack added the bug Something isn't working label Apr 26, 2018
@matthewjablack matthewjablack changed the title Can transfer excess infinitely Can transfer excess funds infinitely Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matthewjablack