Added Error messages on Gateway_Balance and Channel_Authorize

src/ripple/rpc/handlers/GatewayBalances.cpp

@@ -78,6 +78,12 @@ doGatewayBalances(RPC::JsonContext& context)
 
     result[jss::account] = toBase58(accountID);
 
+    if (!ledger->exists(keylet::account(accountID)) && context.apiVersion > 1u)
+    {
+        RPC::inject_error(rpcACT_NOT_FOUND, result);
+        return result;
+    }
+
     // Parse the specified hotwallet(s), if any
     std::set<AccountID> hotWallets;
 
@@ -116,7 +122,18 @@ doGatewayBalances(RPC::JsonContext& context)
 
         if (!valid)
         {
-            result[jss::error] = "invalidHotWallet";
+            // The documentation states that invalidParams is used when
+            // One or more fields are specified incorrectly.
+            // invalidHotwallet should be used when the account exists, but does
+            // not have currency issued by the account from the request.
+            if (context.apiVersion < 2u)
+            {
+                result[jss::error] = "invalidHotWallet";
+            }
+            else
+            {
+                result[jss::error] = "invalidParams";
+            }
             return result;
         }
     }

src/ripple/rpc/handlers/PayChanClaim.cpp

@@ -55,7 +55,7 @@ doChannelAuthorize(RPC::JsonContext& context)
         return RPC::missing_field_error(jss::secret);
 
     Json::Value result;
-    auto const [pk, sk] = RPC::keypairForSignature(params, result);
+    auto const [pk, sk] = RPC::keypairForSignature(params, result, context);
     if (RPC::contains_error(result))
         return result;
 

src/ripple/rpc/impl/RPCHelpers.cpp

@@ -846,7 +846,10 @@ getSeedFromRPC(Json::Value const& params, Json::Value& error)
 }
 
 std::pair<PublicKey, SecretKey>
-keypairForSignature(Json::Value const& params, Json::Value& error)
+keypairForSignature(
+    Json::Value const& params,
+    Json::Value& error,
+    std::optional<std::reference_wrapper<JsonContext>> context)
 {
     bool const has_key_type = params.isMember(jss::key_type);
 
@@ -900,7 +903,14 @@ keypairForSignature(Json::Value const& params, Json::Value& error)
 
         if (!keyType)
         {
-            error = RPC::invalid_field_error(jss::key_type);
+            if (context.has_value() && context.value().get().apiVersion > 1)
+            {
+                error = RPC::make_error(rpcBAD_KEY_TYPE);
+            }
+            else
+            {
+                error = RPC::invalid_field_error(jss::key_type);
+            }
             return {};
         }
 

src/ripple/rpc/impl/RPCHelpers.h

@@ -207,7 +207,10 @@ std::optional<Seed>
 parseRippleLibSeed(Json::Value const& params);
 
 std::pair<PublicKey, SecretKey>
-keypairForSignature(Json::Value const& params, Json::Value& error);
+keypairForSignature(
+    Json::Value const& params,
+    Json::Value& error,
+    std::optional<std::reference_wrapper<JsonContext>> context = std::nullopt);
 
 /**
  * API version numbers used in API version 1

src/test/app/PayChan_test.cpp

@@ -24,9 +24,9 @@
 #include <ripple/protocol/PayChan.h>
 #include <ripple/protocol/TxFlags.h>
 #include <ripple/protocol/jss.h>
-#include <test/jtx.h>
-
+#include <ripple/rpc/impl/RPCHelpers.h>
 #include <chrono>
+#include <test/jtx.h>
 
 namespace ripple {
 namespace test {
@@ -1160,6 +1160,50 @@ struct PayChan_test : public beast::unit_test::suite
             bob.human());
     }
 
+    void
+    testAccountChannelAuthorize(FeatureBitset features, unsigned int apiVersion)
+    {
+        testcase("PayChan Channel_Auth RPC Api " + std::to_string(apiVersion));
+        using namespace jtx;
+        using namespace std::literals::chrono_literals;
+
+        Env env{*this, features};
+        auto const alice = Account("alice");
+        auto const bob = Account("bob");
+        auto const charlie = Account("charlie", KeyType::ed25519);
+        env.fund(XRP(10000), alice, bob, charlie);
+        auto const pk = alice.pk();
+        auto const settleDelay = 3600s;
+        auto const channelFunds = XRP(1000);
+        auto const chan1Str = to_string(channel(alice, bob, env.seq(alice)));
+        env(create(alice, bob, channelFunds, settleDelay, pk));
+        env.close();
+
+        // test for api_version 2
+        Json::Value args{Json::objectValue};
+        args[jss::api_version] = apiVersion;
+        args[jss::channel_id] = chan1Str;
+        args[jss::key_type] = "ed255191";
+        args[jss::seed] = "snHq1rzQoN2qiUkC3XF5RyxBzUtN";
+        args[jss::amount] = 51110000;
+        if (apiVersion < 2u)
+        {
+            auto const rs = env.rpc(
+                "json",
+                "channel_authorize",
+                args.toStyledString())[jss::result];
+            BEAST_EXPECT(rs[jss::error] == "invalidParams");
+        }
+        else
+        {
+            auto const rs = env.rpc(
+                "json",
+                "channel_authorize",
+                args.toStyledString())[jss::result];
+            BEAST_EXPECT(rs[jss::error] == "badKeyType");
+        }
+    }
+
     void
     testAuthVerifyRPC(FeatureBitset features)
     {
@@ -2139,6 +2183,12 @@ struct PayChan_test : public beast::unit_test::suite
         testAccountChannelsRPC(features);
         testAccountChannelsRPCMarkers(features);
         testAccountChannelsRPCSenderOnly(features);
+        for (auto testVersion = RPC::apiMinimumSupportedVersion;
+             testVersion <= RPC::apiBetaVersion;
+             ++testVersion)
+        {
+            testAccountChannelAuthorize(features, testVersion);
+        }
         testAuthVerifyRPC(features);
         testOptionalFields(features);
         testMalformedPK(features);