diff --git a/.ci-config/rippled.cfg b/.ci-config/rippled.cfg index 673c1e3505..67cd044ebd 100644 --- a/.ci-config/rippled.cfg +++ b/.ci-config/rippled.cfg @@ -188,3 +188,4 @@ fixNFTokenPageLinks fixInnerObjTemplate2 fixEnforceNFTokenTrustline fixReducedOffersV2 +DynamicNFT diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 012537fa3f..1b8531b826 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -4,7 +4,7 @@ name: Node.js CI env: - RIPPLED_DOCKER_IMAGE: rippleci/rippled:2.3.0-rc1 + RIPPLED_DOCKER_IMAGE: rippleci/rippled:develop on: push: diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 2b3f978dce..d5f074d102 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -64,7 +64,7 @@ From the top-level xrpl.js folder (one level above `packages`), run the followin ```bash npm install # sets up the rippled standalone Docker container - you can skip this step if you already have it set up -docker run -p 6006:6006 --rm -it --name rippled_standalone --volume $PWD/.ci-config:/etc/opt/ripple/ --entrypoint bash rippleci/rippled:2.3.0-rc1 -c 'rippled -a' +docker run -p 6006:6006 --rm -it --name rippled_standalone --volume $PWD/.ci-config:/etc/opt/ripple/ --entrypoint bash rippleci/rippled:develop -c 'rippled -a' npm run build npm run test:integration ``` @@ -76,7 +76,7 @@ Breaking down the command: `--name rippled_standalone` is an instance name for clarity * `--volume $PWD/.ci-config:/etc/opt/ripple/` identifies the `rippled.cfg` and `validators.txt` to import. It must be an absolute path, so we use `$PWD` instead of `./`. * `rippleci/rippled` is an image that is regularly updated with the latest `rippled` releases -* `--entrypoint bash rippleci/rippled:2.3.0-rc1` manually overrides the entrypoint (for versions of rippled >= 2.3.0) +* `--entrypoint bash rippleci/rippled:develop` manually overrides the entrypoint (for the latest version of rippled on the `develop` branch) * `-c 'rippled -a'` provides the bash command to start `rippled` in standalone mode from the manual entrypoint ### Browser Tests @@ -92,7 +92,7 @@ This should be run from the `xrpl.js` top level folder (one above the `packages` ```bash npm run build # sets up the rippled standalone Docker container - you can skip this step if you already have it set up -docker run -p 6006:6006 --rm -it --name rippled_standalone --volume $PWD/.ci-config:/etc/opt/ripple/ --entrypoint bash rippleci/rippled:2.3.0-rc1 -c 'rippled -a' +docker run -p 6006:6006 --rm -it --name rippled_standalone --volume $PWD/.ci-config:/etc/opt/ripple/ --entrypoint bash rippleci/rippled:develop -c 'rippled -a' npm run test:browser ``` diff --git a/packages/ripple-binary-codec/src/enums/definitions.json b/packages/ripple-binary-codec/src/enums/definitions.json index 1a9975dffa..e50863370b 100644 --- a/packages/ripple-binary-codec/src/enums/definitions.json +++ b/packages/ripple-binary-codec/src/enums/definitions.json @@ -3105,6 +3105,7 @@ "NFTokenCancelOffer": 28, "NFTokenCreateOffer": 27, "NFTokenMint": 25, + "NFTokenModify": 61, "OfferCancel": 8, "OfferCreate": 7, "OracleDelete": 52, @@ -3113,8 +3114,8 @@ "PaymentChannelClaim": 15, "PaymentChannelCreate": 13, "PaymentChannelFund": 14, - "PermissionedDomainSet": 61, - "PermissionedDomainDelete": 62, + "PermissionedDomainSet": 62, + "PermissionedDomainDelete": 63, "SetFee": 101, "SetRegularKey": 5, "SignerListSet": 12,